Quiz Creation Select Resources - Keyword search

[AlexVelezLl]

Summary

This PR adds a search input in Quiz Creation Select resources Side Panel.

Preview

Compartir.pantalla.-.2024-02-15.16_13_05.mp4

References

closes #11786

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[AlexVelezLl]

For some reason there was a case where workingResourcePool was undefined here and it didn't let me move forward

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b13.dev0_git.566.gb1df74b0.pex
Windows Installer (EXE)	kolibri-0.16.0b13.dev0+git.566.gb1df74b0-unsigned.exe
Debian Package	kolibri_0.16.0b13.dev0+git.566.gb1df74b0-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b13.dev0+git.566.gb1df74b0-0.4.0.dmg
Android Package (APK)	kolibri-0.16.0b13.dev0+git.566.gb1df74b0-0.1.0-debug.apk
TAR file	kolibri-0.16.0b13.dev0+git.566.gb1df74b0.tar.gz
WHL file	kolibri-0.16.0b13.dev0+git.566.gb1df74b0-py2.py3-none-any.whl

[nucleogenesis]

This looks great @AlexVelezLl - I'm going to list a few thoughts here but won't approve or request changes quite yet.

• The changes I've made to the routing in Fix: Side panel closing confirmation & logic in child component #11862 fix most (if not all) of the bugs I'm seeing when testing this (ie, cannot save changes after adding search result, back button weirdness,
• One thing that we didn't consider while working on this was setting the local loading state whenever we're fetching search results. When we run this locally it's so fast that it's hard to see how bad the UX would be when the load takes a few seconds. That said, however, I think that this is an issue we can better handle in a follow-up as this is not solely a problem w/ the search loading but with all of the loading in the side panel right now.

Great work - I'm going to wait for review on my latest changes to the PR I noted above and if that goes through, I think I'll merge this PR and then fix conflicts any conflicts it creates in my PR before merging that.

update - I've added a link to the project tech debt tracker. Updating how the loading states are managed will jive well with a general follow-up in how we manage the loading states altogether which I will work on after wrapping up question replacement early next week.

[rtibbles]

One thing that looks suspect to me - conditionalizing setup exports will not let the component be reactive to changes in searchQuery state.

[rtibbles]

Unless the component is being torn down and recreated when the searchQuery updates (which I think we are trying to avoid happen), this value will not recompute.

You may want to instead make the fetchMoreQuizResources function behave conditionally on the searchQuery instead.

Also, it should be searchQuery.value I believe that we conditionalize on?

[AlexVelezLl]

Thanks @rtibbles! I have updated it 👐

Comments addressed

[nucleogenesis]

Thanks for the updates and comments Alex & Richard.