-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiz Creation Select Resources - Keyword search #11887
Merged
nucleogenesis
merged 7 commits into
learningequality:develop
from
AlexVelezLl:eqm-keyword-search
Feb 26, 2024
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6547e47
Add LessonsSearchBox
AlexVelezLl 948da07
Add search results
AlexVelezLl bcb3cae
add fetch more
AlexVelezLl 9a5e091
Lint files
AlexVelezLl 7480e83
Fix clear search
AlexVelezLl 9f6f917
Refactor
AlexVelezLl 64d4556
Fix fech more resources condition
AlexVelezLl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,7 +105,10 @@ | |
}, | ||
methods: { | ||
handleClosePanel() { | ||
if (this.workingResourcePool.length > this.activeResourcePool.length) { | ||
if ( | ||
this.workingResourcePool && | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For some reason there was a case where |
||
this.workingResourcePool.length > this.activeResourcePool.length | ||
) { | ||
this.showConfirmationModal = true; | ||
} else { | ||
this.$router.replace(this.closePanelRoute); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless the component is being torn down and recreated when the searchQuery updates (which I think we are trying to avoid happen), this value will not recompute.
You may want to instead make the fetchMoreQuizResources function behave conditionally on the searchQuery instead.
Also, it should be
searchQuery.value
I believe that we conditionalize on?