Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz creation: Snackbar improvements #12080

Merged

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Apr 11, 2024

Summary

Replace snackbar support in route.query with direct calls to the createSnackbar action. And ensures that these are not deleted when entering any of the skipLoading routes

References

Closes #12038.

Reviewer guidance

Play around with the Quiz Editor saving sections, replacing questions, removing sections, go back from the Side Panel, and snackbar should behave consistently.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: very large labels Apr 11, 2024
@AlexVelezLl AlexVelezLl force-pushed the 12038-snackbar-improvements branch from d00046a to 0c08589 Compare April 19, 2024 16:00
@AlexVelezLl AlexVelezLl marked this pull request as ready for review April 19, 2024 16:01
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the snackbars and they all work perfectly. This is good to merge IMO, thank you @AlexVelezLl

I did note one bug unrelated to your changes in #12037 (I confirmed it is unrelated by replicating it on develop).

@marcellamaki
Copy link
Member

@radinamatic @pcenov if you could do a QA double-check here, then we will be good to go! thank you :) there should be some notes of what to test in the issue that Alex linked in the description

@pcenov
Copy link
Member

pcenov commented Apr 24, 2024

Hi @AlexVelezLl and @nucleogenesis - I am not seeing any snackbars in the following scenarios:

  • user deletes questions from the list
  • user rearranges questions in the list
  • user rearranges the section order in the 'Section settings' modal and closes the modal without clicking 'Apply settings'
2024-04-24_12-23-24.mp4

Not sure if this in scope for this PR - if not, I can file a separate issue.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like @AlexVelezLl and @nucleogenesis do indeed want the three scenarios @pcenov has described to be covered here, so blocking merge until that has happened.

@AlexVelezLl AlexVelezLl force-pushed the 12038-snackbar-improvements branch from 0341a6b to 48f85a4 Compare May 6, 2024 13:30
@AlexVelezLl
Copy link
Member Author

Hi @nucleogenesis @pcenov I've added the missing snackbar notifications:

Compartir.pantalla.-.2024-05-06.08_31_55.mp4

@nucleogenesis I saw that the changes to the section order were made immediately after the drag and drop, and it didn't wait until the user clicked on the "apply changes" button, so I added a new ref for the section order within the component and added a sectionOrderChanged check before saving the changes here. Let me know if this is correct.

@pcenov
Copy link
Member

pcenov commented May 13, 2024

Thanks @AlexVelezLl - I confirm that the snackabar notifications are displayed now in the first 2 cases, and that the section order change is applied only after the user has clicked the 'Apply settings' button.

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 💯 👏🏽 :shipit:

@rtibbles rtibbles dismissed their stale review May 14, 2024 22:01

Changes have been addressed.

@AlexVelezLl AlexVelezLl force-pushed the 12038-snackbar-improvements branch from 48f85a4 to 4887b4d Compare May 15, 2024 05:08
@AlexVelezLl AlexVelezLl merged commit 446aec6 into learningequality:develop May 16, 2024
31 checks passed
@AlexVelezLl AlexVelezLl deleted the 12038-snackbar-improvements branch May 16, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: backend Python, databases, networking, filesystem... DEV: frontend SIZE: small SIZE: very large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiz creation: Snackbars improvements
6 participants