-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiz creation: Snackbar improvements #12080
Quiz creation: Snackbar improvements #12080
Conversation
Build Artifacts
|
d00046a
to
0c08589
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the snackbars and they all work perfectly. This is good to merge IMO, thank you @AlexVelezLl
I did note one bug unrelated to your changes in #12037 (I confirmed it is unrelated by replicating it on develop).
@radinamatic @pcenov if you could do a QA double-check here, then we will be good to go! thank you :) there should be some notes of what to test in the issue that Alex linked in the description |
Hi @AlexVelezLl and @nucleogenesis - I am not seeing any snackbars in the following scenarios:
2024-04-24_12-23-24.mp4Not sure if this in scope for this PR - if not, I can file a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like @AlexVelezLl and @nucleogenesis do indeed want the three scenarios @pcenov has described to be covered here, so blocking merge until that has happened.
0341a6b
to
48f85a4
Compare
Hi @nucleogenesis @pcenov I've added the missing snackbar notifications: Compartir.pantalla.-.2024-05-06.08_31_55.mp4@nucleogenesis I saw that the changes to the section order were made immediately after the drag and drop, and it didn't wait until the user clicked on the "apply changes" button, so I added a new ref for the section order within the component and added a |
Thanks @AlexVelezLl - I confirm that the snackabar notifications are displayed now in the first 2 cases, and that the section order change is applied only after the user has clicked the 'Apply settings' button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA passes, good to go! 💯 👏🏽
48f85a4
to
4887b4d
Compare
Summary
Replace snackbar support in route.query with direct calls to the
createSnackbar
action. And ensures that these are not deleted when entering any of theskipLoading
routesReferences
Closes #12038.
Reviewer guidance
Play around with the Quiz Editor saving sections, replacing questions, removing sections, go back from the Side Panel, and snackbar should behave consistently.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)