Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API and CSV fixes #9523

Merged
merged 9 commits into from
Jun 21, 2022

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 20, 2022

Summary

  • Updates auth API permissions to restrict access for non-admins
  • Updates ValuesViewset to restore default filtering behaviour when doing object detail queries
  • Filters both detail and list endpoints in permissions filter
  • Adds sanitization to CSV writing

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles force-pushed the permissions_fixes branch from bd8e646 to 95e336d Compare June 20, 2022 21:35
@radinamatic
Copy link
Member

  • EXE asset installed on Windows 10 ✔️
  • imported a CSV with 70 users ✔️
  • 2 new classes created, learners enrolled, coaches assigned ✔️
  • class deleted ✔️
  • 3 groups created, learners searched for and assigned ✔️
  • group deleted ✔️
  • details added to 2 users ✔️
  • CSV exported and checked to confirm all the changes ✔️

No sign of UI issues and/or errors in the console, good to go! 👍🏽

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA is looking good, :shipit:!

Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lThere's one point I don't quite understand so it would be great if you can comment it.
For the most part, loving these changes

kolibri/core/api.py Outdated Show resolved Hide resolved
kolibri/core/auth/api.py Outdated Show resolved Hide resolved
kolibri/core/auth/permissions/base.py Outdated Show resolved Hide resolved
kolibri/core/auth/api.py Outdated Show resolved Hide resolved
@rtibbles
Copy link
Member Author

Have addressed all comments - as long as tests pass, this should be good to merge.

@rtibbles rtibbles merged commit df775b5 into learningequality:release-v0.15.x Jun 21, 2022
@rtibbles rtibbles deleted the permissions_fixes branch June 21, 2022 17:48
@rtibbles rtibbles mentioned this pull request Jun 30, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants