Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quiz display for non-admins #9545

Merged

Conversation

rtibbles
Copy link
Member

Summary

  • Displaying exams in learn was using the ClassroomResource which with the security fixes in API and CSV fixes #9523 is no longer accessible to non-admins
  • Updates the code to use the LearnerClassroomResource that is used in the rest of learn

References

Fixes #9544

Reviewer guidance

Can you view a quiz as a learner? (must not be an admin or superadmin)

Screencast.from.06-30-2022.12.34.31.PM.webm.mp4

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jun 30, 2022
@rtibbles rtibbles added this to the Planned Patch 4: Coach usability improvements milestone Jun 30, 2022
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

Code makes sense, and I've checked:
Taking quiz as learner
Screen Shot 2022-06-30 at 4 17 35 PM

Learner quiz report
Screen Shot 2022-06-30 at 4 16 56 PM

Coach: Difficult Questions
Screen Shot 2022-06-30 at 4 16 38 PM

Coach: Learner report
Screen Shot 2022-06-30 at 4 16 30 PM

Coach: Quiz preview
Screen Shot 2022-06-30 at 4 14 10 PM

Not sure if I have missed anything in the critical workflows, @radinamatic - but if otherwise, this should be good to merge.

@radinamatic
Copy link
Member

radinamatic commented Jun 30, 2022

Tested with the DEB asset in Ubuntu 18.04, and with APK on Android 9.0 phone, all quiz learner and coach workflows look good!

Selection_025

Selection_026

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 :shipit:!

@marcellamaki marcellamaki merged commit 66023fd into learningequality:release-v0.15.x Jun 30, 2022
@radinamatic
Copy link
Member

@rtibbles Just a reminder that this should be ported to develop as the same issue is extant there (confirmed by @pcenov who did a critical workflows pass on this build today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants