mark_as_read! fails with exception on Rails 6+ if Reader has default_scope defined #120

k-rudy · 2020-10-29T12:53:41Z

Hey guys,

We're having the following issue:
If the reader has default_scope defined, running mark_as_read! on readable will raise an exception:

ActiveRecord::RecordInvalid: Validation failed: Reader must exist

This is happening as belongs_to definition of the ReadMark needs to specify optional: true while it doesn't.

Thank you,
Kon.

The text was updated successfully, but these errors were encountered:

…dermann#121) * Added optional: true to read_marks [Fixes ledermann#120] * Added specs for the optional reader case [Fixes ledermann#120]

k-rudy added a commit to Profinda/unread that referenced this issue Oct 29, 2020

Added optional: true to read_marks [Fixes ledermann#120]

2c4ec96

k-rudy added a commit to Profinda/unread that referenced this issue Oct 30, 2020

Added specs for the optional reader case [Fixes ledermann#120]

da17063

ledermann closed this as completed in 0f1b242 Oct 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mark_as_read! fails with exception on Rails 6+ if Reader has default_scope defined #120

mark_as_read! fails with exception on Rails 6+ if Reader has default_scope defined #120

k-rudy commented Oct 29, 2020

mark_as_read! fails with exception on Rails 6+ if Reader has default_scope defined #120

mark_as_read! fails with exception on Rails 6+ if Reader has default_scope defined #120

Comments

k-rudy commented Oct 29, 2020