Added optional: true to reader's belongs_to [Fixes #120] #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! Would you mind adding a test to verify your change? |
k-rudy
changed the title
|
@ledermann done |
|
Thanks a lot, @k-rudy! |
HwakyoungLee
pushed a commit
to grepp/unread
that referenced
this pull request
May 12, 2023
…dermann#121) * Added optional: true to read_marks [Fixes ledermann#120] * Added specs for the optional reader case [Fixes ledermann#120]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue in Rails 6+ that has by default
belongs_to_required_by_default = truesetting enabled.As a a result if any reader defines default scope and reader instance does not match that scope
mark_as_read!fails withReader must existthenThanks.