Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS initial index issue && Bump version #516

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

AtticusFetch
Copy link

@AtticusFetch AtticusFetch commented Aug 12, 2017

Version

  • react-native-swiper v1.5.9
  • react-native v0.44.3

Expected behaviour

Index page is displayed after render

Actual behaviour

First item is displayed, with paging showing correct dot highlighted.

Steps to reproduce

For non-obvious bugs, please fork this component, modify Example project to reproduce your issue and include link here.

  1. Create swiper that takes full width of page
  2. Set non-zero index
  3. Observe first page (with zero index) rendered as initial.

@AtticusFetch AtticusFetch changed the title Bump version to 1.5.10 Fix iOS initial index issue Aug 13, 2017
@AtticusFetch
Copy link
Author

Possibly related to this issue

@AtticusFetch AtticusFetch changed the title Fix iOS initial index issue Fix iOS initial index issue && Bump version Aug 13, 2017
@xxxMortxxx
Copy link

This merge request is really good! Definitely should be merged as fast as possible

@arribbar arribbar mentioned this pull request Aug 14, 2017
@arribbar
Copy link
Collaborator

It might fix this issue #503.

@arribbar arribbar merged commit 6fd0c3d into leecade:master Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants