Fix 'index' prop on iOS #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit ff12771 breaks the `index` prop on `iOS` which means you can't set the first slide anymore. Since the condition on line `258` is always `false`, `this.state.offset` wasn't set on the first render.
|
Thanks for this PR. |
|
Nevermind, I missed it 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it a bugfix ?
Yes, commit ff12771 breaks the
indexprop oniOSwhich means you can't set the first slide anymore.Is it a new feature ?
Nope
Describe what you've done:
The condition on line
258is alwaysfalse,this.state.offsetwasn't set on the first render.How to test it ?
Render the swiper with an
indexset to an int, you can see it starts properly on this value.