Solved grammar mistakes, justifies sentences, updated home page content. #35
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/withmadico/legesher/lp62t5goo |
index.html
Outdated
|
|
||
| <p class="text-sm">Innovation, creativity, and collaboration should never be lost in translation. That’s why we created Legesher! | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Please explain the purpose of the addition of these newlines in both this section and in lines 293-295
There was a problem hiding this comment.
Sorry, I haven't made those gaps originally. Github done that due to merge conflict.
index.html
Outdated
|
|
||
| <h2 class="section-title mt-0">Be notified</h2> | ||
|
|
There was a problem hiding this comment.
Thanks for the suggestion 👍, but I prefer the prior version of the copy for this section.
index.html
Outdated
| <p class="text-sm">We always want to add new spoken and programming languages to our repository. Please lege-<u>share</u> our mission. | ||
| </br></br>From beginners to professionals, learning how to code to collaborating with diverse teams around the world, Legesher connects us all.</p> |
There was a problem hiding this comment.
You're on the right track, let's refine this a little more.
The first
sentence's purpose is to encourage new dialect translations to be added / reviewed.
The second sentence is to showcase the different use cases of the tool:
- people just starting to learn how to code
- professional developers collaborating in (diverse) teams
|
I have pushed a new update according to your recommendations and refined the text more. Can you merge it? I really need this for Hacktoberfest. P.S: How to join to Legesher? I have subscribed to the mail list, is it enough? |
|
Hey @Yutyo, that's awesome you're doing Hacktoberfest for it truly helps open source project receive quality contributions. It's best to tackle on bugs or new features that are properly described in issues, so the requirements of the pull request are clear. I'm going to close this pull request, as this copy of the home page needs to be clearly described/discussed in an issue. If you're trying to finalize your hacktoberfest PR's, .this is a great place. I will accept multiple PR's if each contribution has at least 10 full entries added to the table. Quality > Quantity |
No description provided.