Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airflow DAGs unable to read credentials from k8s secret #504

Closed
aliaksandr-d opened this issue Sep 28, 2018 · 3 comments · Fixed by #515
Closed

Airflow DAGs unable to read credentials from k8s secret #504

aliaksandr-d opened this issue Sep 28, 2018 · 3 comments · Fixed by #515
Assignees
Labels
bug [Fixed] for any bug fixes.

Comments

@aliaksandr-d
Copy link
Member

Currently Airflow Hooks are trying to get credentials connections from K8s secrets, but it's forbidden for them to read any secrets from k8s. Need to update RBAC

@aliaksandr-d aliaksandr-d added the bug [Fixed] for any bug fixes. label Sep 28, 2018
@aliaksandr-d aliaksandr-d self-assigned this Sep 28, 2018
@kirillmakhonin
Copy link
Member

As we discussed previously DAGs can load credentials in two ways:

  1. AWS creds using kube2iam
  2. Non-aws creds using Airflow Connections. Airflow Connections are configurable using deployment secret (section airflow.connections)

@aliaksandr-d
Copy link
Member Author

@kirillmakhonin airflow.connections are set only during cluster creation and legion deployment. we need the ability to update non-aws credentials without cluster recreation and not in Airflow UI. The idea is that non-aws credentials can be stored in k8s secret, that is updated directly.

@aliaksandr-d
Copy link
Member Author

After discussion with @dsuslov , we decided to store all connections credentials in one k8s secret map.
It requires:

  1. hooks update to read credentials from one k8s secret
  2. worker rbac update to give access to a single k8s secret.

leshchanka-aliaksandr pushed a commit that referenced this issue Oct 4, 2018
aliaksandr-d added a commit that referenced this issue Oct 16, 2018
aliaksandr-d pushed a commit that referenced this issue Oct 16, 2018
aliaksandr-d added a commit that referenced this issue Oct 16, 2018
aliaksandr-d pushed a commit that referenced this issue Oct 18, 2018
aliaksandr-d added a commit that referenced this issue Oct 18, 2018
aliaksandr-d pushed a commit that referenced this issue Oct 19, 2018
aliaksandr-d added a commit that referenced this issue Oct 19, 2018
aliaksandr-d pushed a commit that referenced this issue Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [Fixed] for any bug fixes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants