[#504] Airflow DAGs unable to read credentials from k8s secret #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leshchanka-aliaksandr
requested review from
akharlamov and
a team
as code owners
|
bot, test all |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Build status: SUCCESS |
kirillmakhonin
requested changes
Oct 15, 2018
| k8s_namespace=os.environ['NAMESPACE'] | ||
| ) | ||
| return Connection(**config_map.data) | ||
| connection_data = yaml.load(config_map.data['data']) |
There was a problem hiding this comment.
Looks like you store all connections in key data. But I guess, it will be better to store each connection info in appropriate named key? And values of each info will be encoded via yaml
kirillmakhonin
approved these changes
Oct 16, 2018
aliaksandr-d
force-pushed
the
feat/504-airflow-cred-in-secret-file
branch
from
ea78e68 to
2e39b5f
Compare
|
bot, test all |
|
Build status: FAILURE |
|
bot, test all |
|
Build status: SUCCESS |
|
bot, test all |
aliaksandr-d
force-pushed
the
feat/504-airflow-cred-in-secret-file
branch
2 times, most recently
from
06bc105 to
b4621d9
Compare
|
bot, test app |
|
Build status: FAILURE |
|
bot, test app |
|
Build status: FAILURE |
aliaksandr-d
force-pushed
the
feat/504-airflow-cred-in-secret-file
branch
from
b4621d9 to
b38ebf3
Compare
|
bot, test app |
|
Build status: SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR close #504