🐛 fix chopper_generator regression introduced in #534 (#549)

lejard-h · Jan 8, 2024 · 33615ed · 33615ed
1 parent 2dc868f
commit 33615ed
Show file tree

Hide file tree

Showing 5 changed files with 71 additions and 3 deletions.
diff --git a/chopper/test/test_service.chopper.dart b/chopper/test/test_service.chopper.dart
diff --git a/chopper/test/test_service.dart b/chopper/test/test_service.dart
@@ -204,6 +204,15 @@ abstract class HttpTestService extends ChopperService {
  @Header('x-double') double? doubleHeader,
  @Header('x-enum') ExampleEnum? enumHeader,
  });
+
+ @Post(path: 'publish')
+ @FactoryConverter(request: FormUrlEncodedConverter.requestFactory)
+ Future<Response<void>> publish(
+ @Field('review_id') final String reviewId,
+ @Field() final List<int> negatives,
+ @Field() final List<int> positives, [
+ @Field() final String? signature,
+ ]);
 }
 
 Request customConvertRequest(Request req) {

diff --git a/chopper_generator/lib/src/generator.dart b/chopper_generator/lib/src/generator.dart
@@ -470,9 +470,7 @@ final class ChopperGenerator
  // ignore: deprecated_member_use
  function.enclosingElement is ClassElement
  // ignore: deprecated_member_use
- ? refer(function.enclosingElement!.name!)
- .property(function.name!)
- .toString()
+ ? '${function.enclosingElement!.name}.${function.name}'
  : function.name!;
 
  static Map<String, ConstantReader> _getAnnotation(

diff --git a/chopper_generator/test/test_service.chopper.dart b/chopper_generator/test/test_service.chopper.dart
diff --git a/chopper_generator/test/test_service.dart b/chopper_generator/test/test_service.dart
@@ -197,6 +197,15 @@ abstract class HttpTestService extends ChopperService {
  @Header('x-double') double? doubleHeader,
  @Header('x-enum') ExampleEnum? enumHeader,
  });
+
+ @Post(path: 'publish')
+ @FactoryConverter(request: FormUrlEncodedConverter.requestFactory)
+ Future<Response<void>> publish(
+ @Field('review_id') final String reviewId,
+ @Field() final List<int> negatives,
+ @Field() final List<int> positives, [
+ @Field() final String? signature,
+ ]);
 }
 
 Request customConvertRequest(Request req) {