Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix chopper_generator regression introduced in #534 #549

Merged
merged 2 commits into from
Jan 8, 2024
Merged

🐛 fix chopper_generator regression introduced in #534 #549

merged 2 commits into from
Jan 8, 2024

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Jan 6, 2024

fixes #546

@techouse techouse added the bug Something isn't working label Jan 6, 2024
@techouse techouse mentioned this pull request Jan 6, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2dc868f) 94.17% compared to head (475d5bb) 94.17%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #549   +/-   ##
========================================
  Coverage    94.17%   94.17%           
========================================
  Files           11       11           
  Lines          481      481           
========================================
  Hits           453      453           
  Misses          28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@techouse
Copy link
Collaborator Author

techouse commented Jan 6, 2024

@JEuler @Guldem would you mind throwing an eye on this ASAP :)

Guldem
Guldem approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@Guldem Guldem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@techouse techouse merged commit 33615ed into develop Jan 8, 2024
6 checks passed
@techouse techouse deleted the fix/issue-546 branch January 8, 2024 16:59
techouse added a commit that referenced this pull request Jan 8, 2024
@techouse
🔖 release v7.1.0
fd67b8e 
# chopper

## 7.1.0

- #545
- #543
- #548

# chopper_generator

## 7.1.0

- #545
- #549
@techouse techouse mentioned this pull request Jan 8, 2024
Closed
techouse added a commit that referenced this pull request Jan 9, 2024
@techouse
🔖 release chopper_generator v7.1.0
1c69ffc 
## 7.1.0

- #545
- #549
@techouse techouse mentioned this pull request Jan 9, 2024
Closed
techouse added a commit that referenced this pull request Jan 9, 2024
@techouse
# chopper
63d7397 
## 7.0.11

- #545
- #543
- #548

# chopper_generator

## 7.0.8

- #545
- #549
@techouse techouse mentioned this pull request Jan 9, 2024
Closed
techouse added a commit that referenced this pull request Jan 9, 2024
@techouse
# chopper
cf31fa6 
## 7.1.0

- #545
- #543
- #548

# chopper_generator

## 7.1.0

- #545
- #549
@techouse techouse mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEuler JEuler JEuler approved these changes

@Guldem Guldem Guldem approved these changes

@lejard-h lejard-h Awaiting requested review from lejard-h lejard-h is a code owner

@meysam1717 meysam1717 Awaiting requested review from meysam1717 meysam1717 is a code owner

@stewemetal stewemetal Awaiting requested review from stewemetal stewemetal is a code owner

Assignees

@JEuler JEuler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chopper_generator 7.0.7 is broken
3 participants
@techouse @JEuler @Guldem