Helper function for fetching errors of specific type #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guldem
requested review from
JEuler,
lejard-h,
meysam1717,
stewemetal and
techouse
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #543 +/- ##
===========================================
+ Coverage 94.02% 94.06% +0.03%
===========================================
Files 10 10
Lines 469 472 +3
===========================================
+ Hits 441 444 +3
Misses 28 28 ☔ View full report in Codecov by Sentry. |
techouse
approved these changes
Jan 2, 2024
|
LGTM. You could add some more explicit tests, though. 😄 |
Not sure what you mean? I find them pretty explicit haha 😅 Could improve to test names though |
That. It just tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added simple helper function for fetching error of a specific type. This could be helpful when a error converter is added to convert error into a custom error object. This reduces the boilerplate needed to get the custom error from the response.
See #429