Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor kube detail components and add KubeEvents automatically to all custom resources #6468

Merged
merged 34 commits into from
Dec 15, 2022
Merged

Refactor kube detail components and add KubeEvents automatically to all custom resources #6468

merged 34 commits into from
Dec 15, 2022

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Oct 25, 2022

resolves #6452

Partial fix for #3770

@Nokel81 Nokel81 added the enhancement New feature or request label Oct 25, 2022
@Nokel81 Nokel81 added this to the 6.2.0 milestone Oct 25, 2022
@Nokel81 Nokel81 requested a review from a team as a code owner October 25, 2022 18:44
@Nokel81 Nokel81 requested review from Iku-turso and jim-docker and removed request for a team October 25, 2022 18:44
@Nokel81 Nokel81 changed the title Refactor kube detail components Refactor kube detail components and add KubeEvents automatically to all custom resources Nov 1, 2022
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Nokel81 Nokel81 force-pushed the refactor-kube-detail-components branch from f3a1eda to a1ac3c7 Compare November 10, 2022 14:45
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Nokel81 Nokel81 force-pushed the refactor-kube-detail-components branch from f17cbb3 to aa2db17 Compare November 14, 2022 18:38
@Nokel81 Nokel81 modified the milestones: 6.2.0, 6.3.0 Nov 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Nokel81
Support Events on CustomResourece details panel
7188342 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove unnecessary check
e9ea1fc 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove legacy KubeObjectMeta use from non-metrics details
5b15d12 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Change orderNumber of default KubeMetaDetails
fc3ed25 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove last use of legacy global getActiveClusterEntity
1a594b9 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Refactor ResourceMetrics to use IAsyncComputed
660dd47 
- Introduce first use for namespace metrics

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Introduce metrics details item for Ingress
f269ba8 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove legacyStore for nodes
382d8b9 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove legacyStore for ingresses
7c5aa6a 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Replace NodeMetrics in details with injectable
a1c9b9a 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Change namespace metrics details to use more injectables
84dbb5f 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Change ingress metrics details to use more injectables
4328f03 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Change PersistentVolumeClaim metrics to be injectable
3518c44 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Change DaemonSet metrics to be injectable
6f73c4d 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Change Deployment metrics to be injectable
8c032ce 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Change Job metrics to be injectable
4264ba0 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Convert Pod metrics to be injectable
836783f 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Make ReplicaSet metrics details injectable
c060a6b 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Make StatefulSet metrics component injectable
d734276 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove dead code
01f66c4 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Introduce fix for metrics components visible on all details
026053d 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Use the new and correct enabled check
4a39e4b 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove legacy global for daemonSetStore
a92c53e 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Switch components to be static to help with React performance
1f78c66 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove legacy store of CronJobs
72f199f 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Make DeploymentReplicaSets injectable to fix build error
d359747 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix up remove dead code
8e67ba2 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Allow use of ResourceMetrics without IAsyncComputed
1444c73 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix metrics not updating correctly
fb95ca8 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Update snapshots because moving KubeObjectMeta out of CustomResourceD…
974a31e 
…etails

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix tests
13ccae9 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Update more snapshots
e76e529 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix test failures due to newer dep versions
1eaf253 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix type errors from new asyncComputed
03322e6 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 force-pushed the refactor-kube-detail-components branch from aa2db17 to 03322e6 Compare December 1, 2022 14:41
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Conflicts have been resolved. A maintainer will review the pull request shortly.

jansav
jansav approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@jansav jansav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@Nokel81 Nokel81 merged commit 83d2b12 into master Dec 15, 2022
@Nokel81 Nokel81 deleted the refactor-kube-detail-components branch December 15, 2022 15:14
@Nokel81 Nokel81 mentioned this pull request Dec 20, 2022
Merged
@gdlx gdlx mentioned this pull request Dec 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansav jansav jansav approved these changes

@Iku-turso Iku-turso Awaiting requested review from Iku-turso Iku-turso is a code owner automatically assigned from lensapp/lens-ide

@jim-docker jim-docker Awaiting requested review from jim-docker jim-docker is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

Custom Resource views should include related events like all inbuilt resources do
2 participants
@Nokel81 @jansav