Refactor kube detail components and add KubeEvents automatically to all custom resources

src/common/k8s-api/endpoints/metrics.api/request-pod-metrics-for-jobs.injectable.ts

@@ -24,7 +24,7 @@ const requestPodMetricsForJobsInjectable = getInjectable({
   instantiate: (di): RequestPodMetricsForJobs => {
     const requestMetrics = di.inject(requestMetricsInjectable);
 
-    return (jobs, namespace, selector) => {
+    return (jobs, namespace, selector = "") => {
       const podSelector = jobs.map(job => `${job.getName()}-[[:alnum:]]{5}`).join("|");
       const opts = { category: "pods", pods: podSelector, namespace, selector };
 

src/common/utils/sort-function.ts

@@ -0,0 +1,16 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+
+/**
+ * Get an ordering function based on the function getter
+ */
+export function byValue<T>(getOrderValue: (src: T) => number): (left: T, right: T) => number {
+  return (left, right) => {
+    const leftValue = getOrderValue(left);
+    const rightValue = getOrderValue(right);
+
+    return leftValue - rightValue;
+  };
+}

src/features/cluster/kube-object-details/extension-api/__snapshots__/disable-kube-object-detail-items-when-cluster-is-not-relevant.test.tsx.snap

@@ -302,11 +302,63 @@ exports[`disable kube object detail items when cluster is not relevant given ext
             <div
               class="drawer-content flex column box grow"
             >
+              <div
+                class="DrawerItem"
+              >
+                <span
+                  class="name"
+                >
+                  Created
+                </span>
+                <span
+                  class="value"
+                >
+                  &lt;unknown&gt;
+                   ago 
+                </span>
+              </div>
+              <div
+                class="DrawerItem"
+              >
+                <span
+                  class="name"
+                >
+                  Name
+                </span>
+                <span
+                  class="value"
+                >
+                  some-name
+                </span>
+              </div>
+              <div
+                class="DrawerItem"
+              >
+                <span
+                  class="name"
+                >
+                  Namespace
+                </span>
+                <span
+                  class="value"
+                >
+                  some-namespace
+                </span>
+              </div>
               <div
                 data-testid="some-kube-object-detail-item"
               >
                 Some detail
               </div>
+              <div>
+                <div
+                  class="DrawerTitle flex gaps align-center title"
+                >
+                  <span>
+                    Events
+                  </span>
+                </div>
+              </div>
             </div>
           </div>
           <div
@@ -792,6 +844,15 @@ exports[`disable kube object detail items when cluster is not relevant given ext
                   some-namespace
                 </span>
               </div>
+              <div>
+                <div
+                  class="DrawerTitle flex gaps align-center title"
+                >
+                  <span>
+                    Events
+                  </span>
+                </div>
+              </div>
             </div>
           </div>
           <div
@@ -1277,6 +1338,15 @@ exports[`disable kube object detail items when cluster is not relevant given not
                   some-namespace
                 </span>
               </div>
+              <div>
+                <div
+                  class="DrawerTitle flex gaps align-center title"
+                >
+                  <span>
+                    Events
+                  </span>
+                </div>
+              </div>
             </div>
           </div>
           <div

src/features/cluster/kube-object-details/extension-api/disable-kube-object-detail-items-when-cluster-is-not-relevant.test.tsx

@@ -19,6 +19,7 @@ import extensionShouldBeEnabledForClusterFrameInjectable from "../../../../rende
 import apiManagerInjectable from "../../../../common/k8s-api/api-manager/manager.injectable";
 import { KubeObjectDetails } from "../../../../renderer/components/kube-object-details";
 import type { ApiManager } from "../../../../common/k8s-api/api-manager";
+import type { KubeObjectStore } from "../../../../common/k8s-api/kube-object.store";
 
 describe("disable kube object detail items when cluster is not relevant", () => {
   let builder: ApplicationBuilder;
@@ -32,16 +33,11 @@ describe("disable kube object detail items when cluster is not relevant", () =>
     builder.setEnvironmentToClusterFrame();
 
     builder.beforeWindowStart((windowDi) => {
-      windowDi.override(
-        apiManagerInjectable,
-        () =>
-          ({
-            getStore: () => ({
-              getByPath: () =>
-                getKubeObjectStub("some-kind", "some-api-version"),
-            }),
-          } as unknown as ApiManager),
-      );
+      windowDi.override(apiManagerInjectable, () => ({
+        getStore: () => ({
+          loadFromPath: async () => getKubeObjectStub("some-kind", "some-api-version"),
+        }) as Partial<KubeObjectStore> as KubeObjectStore,
+      }) as Partial<ApiManager> as ApiManager);
 
       windowDi.unoverride(extensionShouldBeEnabledForClusterFrameInjectable);
 

src/features/cluster/kube-object-details/extension-api/reactively-hide-kube-object-detail-item.test.tsx

@@ -16,6 +16,7 @@ import { KubeObject } from "../../../../common/k8s-api/kube-object";
 import apiManagerInjectable from "../../../../common/k8s-api/api-manager/manager.injectable";
 import { KubeObjectDetails } from "../../../../renderer/components/kube-object-details";
 import type { ApiManager } from "../../../../common/k8s-api/api-manager";
+import type { KubeObjectStore } from "../../../../common/k8s-api/kube-object.store";
 
 describe("reactively hide kube object detail item", () => {
   let builder: ApplicationBuilder;
@@ -28,16 +29,11 @@ describe("reactively hide kube object detail item", () => {
     builder.setEnvironmentToClusterFrame();
 
     builder.beforeWindowStart((windowDi) => {
-      windowDi.override(
-        apiManagerInjectable,
-        () =>
-          ({
-            getStore: () => ({
-              getByPath: () =>
-                getKubeObjectStub("some-kind", "some-api-version"),
-            }),
-          } as unknown as ApiManager),
-      );
+      windowDi.override(apiManagerInjectable, () => ({
+        getStore: () => ({
+          loadFromPath: async () => getKubeObjectStub("some-kind", "some-api-version"),
+        }) as Partial<KubeObjectStore> as KubeObjectStore,
+      }) as Partial<ApiManager> as ApiManager);
 
       runInAction(() => {
         windowDi.register(testRouteInjectable, testRouteComponentInjectable);

src/renderer/api/catalog/entity/metrics-details-component-enabled.injectable.ts

@@ -0,0 +1,32 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable";
+import { computed } from "mobx";
+import type { ClusterMetricsResourceType } from "../../../../common/cluster-types";
+import currentKubeObjectInDetailsInjectable from "../../../components/kube-object-details/current-kube-object-in-details.injectable";
+import enabledMetricsInjectable from "./metrics-enabled.injectable";
+
+const metricsDetailsComponentEnabledInjectable = getInjectable({
+  id: "metrics-details-component-enabled",
+  instantiate: (di, kind) => {
+    const metricsEnabled = di.inject(enabledMetricsInjectable, kind);
+    const currentKubeObjectInDetails = di.inject(currentKubeObjectInDetailsInjectable);
+
+    return computed(() => {
+      const current = currentKubeObjectInDetails.value.get();
+
+      if (!current?.object) {
+        return false;
+      }
+
+      return current.object.kind == kind && metricsEnabled.get();
+    });
+  },
+  lifecycle: lifecycleEnum.keyedSingleton({
+    getInstanceKey: (di, kind: ClusterMetricsResourceType) => kind,
+  }),
+});
+
+export default metricsDetailsComponentEnabledInjectable;

src/renderer/api/catalog/entity/metrics-enabled.injectable.ts

@@ -0,0 +1,22 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable";
+import { computed } from "mobx";
+import type { ClusterMetricsResourceType } from "../../../../common/cluster-types";
+import getActiveClusterEntityInjectable from "./get-active-cluster-entity.injectable";
+
+const enabledMetricsInjectable = getInjectable({
+  id: "enabled-metrics",
+  instantiate: (di, kind) => {
+    const getActiveClusterEntity = di.inject(getActiveClusterEntityInjectable);
+
+    return computed(() => !getActiveClusterEntity()?.isMetricHidden(kind));
+  },
+  lifecycle: lifecycleEnum.keyedSingleton({
+    getInstanceKey: (di, kind: ClusterMetricsResourceType) => kind,
+  }),
+});
+
+export default enabledMetricsInjectable;

src/renderer/components/+config-autoscalers/hpa-details.tsx

@@ -16,7 +16,6 @@ import type { HorizontalPodAutoscalerMetricSpec, HorizontalPodAutoscalerMetricTa
 import { HorizontalPodAutoscaler, HpaMetricType } from "../../../common/k8s-api/endpoints/horizontal-pod-autoscaler.api";
 import { Table, TableCell, TableHead, TableRow } from "../table";
 import type { ApiManager } from "../../../common/k8s-api/api-manager";
-import { KubeObjectMeta } from "../kube-object-meta";
 import logger from "../../../common/logger";
 import type { GetDetailsUrl } from "../kube-detail-params/get-details-url.injectable";
 import { withInjectables } from "@ogre-tools/injectable-react";
@@ -121,8 +120,6 @@ class NonInjectedHpaDetails extends React.Component<HpaDetailsProps & Dependenci
 
     return (
       <div className="HpaDetails">
-        <KubeObjectMeta object={hpa}/>
-
         <DrawerItem name="Reference">
           {scaleTargetRef && (
             <Link to={getDetailsUrl(apiManager.lookupApiLink(scaleTargetRef, hpa))}>

src/renderer/components/+config-leases/lease-details.tsx

@@ -9,7 +9,6 @@ import React from "react";
 import { observer } from "mobx-react";
 import { DrawerItem } from "../drawer";
 import type { KubeObjectDetailsProps } from "../kube-object-details";
-import { KubeObjectMeta } from "../kube-object-meta";
 import type { Lease } from "../../../common/k8s-api/endpoints";
 
 export interface LeaseDetailsProps extends KubeObjectDetailsProps<Lease> {
@@ -23,8 +22,6 @@ export class LeaseDetails extends React.Component<LeaseDetailsProps> {
 
     return (
       <div className="LeaseDetails">
-        <KubeObjectMeta object={lease} />
-
         <DrawerItem name="Holder Identity">
           {lease.getHolderIdentity()}
         </DrawerItem>

src/renderer/components/+config-limit-ranges/limit-range-details.tsx

@@ -10,7 +10,6 @@ import { observer } from "mobx-react";
 import type { KubeObjectDetailsProps } from "../kube-object-details";
 import type { LimitRangeItem } from "../../../common/k8s-api/endpoints/limit-range.api";
 import { LimitPart, LimitRange, Resource } from "../../../common/k8s-api/endpoints/limit-range.api";
-import { KubeObjectMeta } from "../kube-object-meta";
 import { DrawerItem } from "../drawer/drawer-item";
 import { Badge } from "../badge";
 import logger from "../../../common/logger";
@@ -73,8 +72,6 @@ export class LimitRangeDetails extends React.Component<LimitRangeDetailsProps> {
 
     return (
       <div className="LimitRangeDetails">
-        <KubeObjectMeta object={limitRange}/>
-
         {containerLimits.length > 0 && (
           <DrawerItem name="Container Limits" labelsOnly>
             {

src/renderer/components/+config-maps/config-map-details.tsx

@@ -14,7 +14,6 @@ import { Input } from "../input";
 import { Button } from "../button";
 import type { KubeObjectDetailsProps } from "../kube-object-details";
 import { ConfigMap } from "../../../common/k8s-api/endpoints";
-import { KubeObjectMeta } from "../kube-object-meta";
 import type { Logger } from "../../../common/logger";
 import type { ConfigMapStore } from "./store";
 import { withInjectables } from "@ogre-tools/injectable-react";
@@ -95,7 +94,6 @@ class NonInjectedConfigMapDetails extends React.Component<ConfigMapDetailsProps
 
     return (
       <div className="ConfigMapDetails">
-        <KubeObjectMeta object={configMap}/>
         {
           data.length > 0 && (
             <>

src/renderer/components/+config-pod-disruption-budgets/pod-disruption-budgets-details.tsx

@@ -11,7 +11,6 @@ import { DrawerItem } from "../drawer";
 import { Badge } from "../badge";
 import type { KubeObjectDetailsProps } from "../kube-object-details";
 import { PodDisruptionBudget } from "../../../common/k8s-api/endpoints";
-import { KubeObjectMeta } from "../kube-object-meta";
 import logger from "../../../common/logger";
 
 export interface PodDisruptionBudgetDetailsProps extends KubeObjectDetailsProps<PodDisruptionBudget> {
@@ -37,8 +36,6 @@ export class PodDisruptionBudgetDetails extends React.Component<PodDisruptionBud
 
     return (
       <div className="PdbDetails">
-        <KubeObjectMeta object={pdb}/>
-
         {selectors.length > 0 && (
           <DrawerItem name="Selector" labelsOnly>
             {

src/renderer/components/+config-priority-classes/priority-classes-details.tsx

@@ -10,7 +10,6 @@ import { observer } from "mobx-react";
 import { DrawerItem } from "../drawer";
 import type { KubeObjectDetailsProps } from "../kube-object-details";
 import type { PriorityClass } from "../../../common/k8s-api/endpoints";
-import { KubeObjectMeta } from "../kube-object-meta";
 
 export interface PriorityClassesDetailsProps extends KubeObjectDetailsProps<PriorityClass> {
 }
@@ -23,8 +22,6 @@ export class PriorityClassesDetails extends React.Component<PriorityClassesDetai
 
     return (
       <div className="PriorityClassesDetails">
-        <KubeObjectMeta object={pc} />
-
         <DrawerItem name="Description">
           {pc.getDescription()}
         </DrawerItem>

src/renderer/components/+config-resource-quotas/resource-quota-details.tsx

@@ -13,7 +13,6 @@ import type { KubeObjectDetailsProps } from "../kube-object-details";
 import { ResourceQuota } from "../../../common/k8s-api/endpoints/resource-quota.api";
 import { LineProgress } from "../line-progress";
 import { Table, TableCell, TableHead, TableRow } from "../table";
-import { KubeObjectMeta } from "../kube-object-meta";
 import logger from "../../../common/logger";
 
 export interface ResourceQuotaDetailsProps extends KubeObjectDetailsProps<ResourceQuota> {
@@ -93,8 +92,6 @@ export class ResourceQuotaDetails extends React.Component<ResourceQuotaDetailsPr
 
     return (
       <div className="ResourceQuotaDetails">
-        <KubeObjectMeta object={quota}/>
-
         <DrawerItem name="Quotas" className="quota-list">
           {renderQuotas(quota)}
         </DrawerItem>

src/renderer/components/+config-runtime-classes/runtime-classes-details.tsx

@@ -10,7 +10,6 @@ import { observer } from "mobx-react";
 import { DrawerItem } from "../drawer";
 import type { KubeObjectDetailsProps } from "../kube-object-details";
 import type { RuntimeClass } from "../../../common/k8s-api/endpoints";
-import { KubeObjectMeta } from "../kube-object-meta";
 import { Badge } from "../badge";
 import { RuntimeClassDetailsTolerations } from "./runtime-classes-details-tolerations";
 
@@ -26,8 +25,6 @@ export class RuntimeClassesDetails extends React.Component<RuntimeClassesDetails
 
     return (
       <div className="RuntimeClassesDetails">
-        <KubeObjectMeta object={rc} />
-
         <DrawerItem name="Handler">
           {rc.getHandler()}
         </DrawerItem>