Make EntitySettingRegistry fully injectable #6604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
requested review from
Iku-turso and
aleksfront
and removed request for
a team
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Nokel81
force-pushed
the
make-EntitySettingRegistry-injectable
branch
from
d0af56b
to
2ae01f3
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
jim-docker
reviewed
Nov 25, 2022
src/renderer/components/+entity-settings/has-settings.injectable.ts
Outdated
Show resolved
Hide resolved
...er/components/+entity-settings/internal-kubernetes-cluster/namespace-settings.injectable.tsx
Outdated
Show resolved
Hide resolved
src/renderer/components/+entity-settings/settings.injectable.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
make-EntitySettingRegistry-injectable
branch
from
921601c
to
78397d7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name
fixes #4875