Bump Horizontal Pod Autoscaler apiBase version #6906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
aleksfront
requested review from
Iku-turso,
jim-docker and
Nokel81
and removed request for
a team
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
ixrock
previously approved these changes
Jan 11, 2023
Comment on lines
81
to
92
| stabilizationWindowSecond?: number; | ||
| selectPolicy?: ScalingPolicySelect; | ||
| policies?: HPAScalingPolicy[]; | ||
| } | ||
|
|
||
| type ScalingPolicySelect = string; | ||
|
|
||
| interface HPAScalingPolicy { | ||
| type: HPAScalingPolicyType; | ||
| value: number; | ||
| periodSeconds: number; | ||
| } |
There was a problem hiding this comment.
nit: too big indentation within both interfaces (comparing to one above)
There was a problem hiding this comment.
There were tabs instead of spaces. Surprisingly, linter ignores that. Fixed.
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
ixrock
approved these changes
Jan 11, 2023
Nokel81
reviewed
Jan 11, 2023
Comment on lines
+232
to
+237
| // Kubernetes < 1.26 | ||
| fallbackApiBases: [ | ||
| "/apis/autoscaling/v2beta2/horizontalpodautoscalers", | ||
| "/apis/autoscaling/v2beta1/horizontalpodautoscalers", | ||
| "/apis/autoscaling/v1/horizontalpodautoscalers", | ||
| ], |
There was a problem hiding this comment.
I don't think these are necessary since the group hasn't changed.
We should be careful though since if a v3 comes out it might change the representation. Though we can add that safety in a future PR.
This was referenced Jan 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2version (introduced in k8s v1.23)Now HPAs get loaded using version
v2for newer k8s. And new fields such asbehaviorandmetricspresented:newer.hpa.apibase.mov
HPAs get loaded using some of the fallback api versions if running older kubernetes:
kube.1.20.hpa.api.version.mov
Fixes #6168
Fixes #6817
Fixes #6827