Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conservative unbinding #187

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Fix missing draw FBO binding when deleting texture

38c092a
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Remove conservative unbinding #187

Fix missing draw FBO binding when deleting texture
38c092a
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jan 21, 2025 in 0s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 266 in src/sl/transpile.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> src/sl/transpile.rs:266:6
    |
266 | impl<'a> FragmentVisitor<'a, Sl> for CollectOutputs {
    |      ^^                  ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
266 - impl<'a> FragmentVisitor<'a, Sl> for CollectOutputs {
266 + impl FragmentVisitor<'_, Sl> for CollectOutputs {
    |

Check warning on line 251 in src/sl/transpile.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> src/sl/transpile.rs:251:6
    |
251 | impl<'a> VertexVisitor<'a, Sl> for CollectVertexBlocks {
    |      ^^                ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
251 - impl<'a> VertexVisitor<'a, Sl> for CollectVertexBlocks {
251 + impl VertexVisitor<'_, Sl> for CollectVertexBlocks {
    |

Check warning on line 210 in src/sl/transpile.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> src/sl/transpile.rs:210:6
    |
210 | impl<'a> UniformVisitor<'a, Sl> for CollectUniforms {
    |      ^^                 ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
210 - impl<'a> UniformVisitor<'a, Sl> for CollectUniforms {
210 + impl UniformVisitor<'_, Sl> for CollectUniforms {
    |

Check warning on line 32 in src/sl/codegen.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
  --> src/sl/codegen.rs:32:6
   |
32 | impl<'a> WriteFuncContext<'a> {
   |      ^^                   ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
32 - impl<'a> WriteFuncContext<'a> {
32 + impl WriteFuncContext<'_> {
   |

Check warning on line 32 in src/sl/sig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this seems like a manual implementation of the non-exhaustive pattern

warning: this seems like a manual implementation of the non-exhaustive pattern
  --> src/sl/sig.rs:27:1
   |
27 | / pub struct VsInput<V> {
28 | |     pub vertex: V,
29 | |     pub vertex_id: U32,
30 | |     pub instance_id: U32,
31 | |     pub(crate) _private: (),
32 | | }
   | |_^
   |
help: remove this field
  --> src/sl/sig.rs:31:5
   |
31 |     pub(crate) _private: (),
   |     ^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive
   = note: `#[warn(clippy::manual_non_exhaustive)]` on by default
help: use the `#[non_exhaustive]` attribute instead
   |
27 + #[non_exhaustive]
28 | pub struct VsInput<V> {
   |

Check warning on line 230 in src/gl/raw/image.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> src/gl/raw/image.rs:230:6
    |
230 | impl<'a> Image<'a> {
    |      ^^        ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
230 - impl<'a> Image<'a> {
230 + impl Image<'_> {
    |

Check warning on line 129 in src/gl/framebuffer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> src/gl/framebuffer.rs:129:10
    |
129 |     impl<'a> FragmentVisitor<'a, Gl> for Visitor {
    |          ^^                  ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
129 -     impl<'a> FragmentVisitor<'a, Gl> for Visitor {
129 +     impl FragmentVisitor<'_, Gl> for Visitor {
    |

Check warning on line 95 in src/gl/context.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
  --> src/gl/context.rs:95:6
   |
95 | impl<'a, VSig, VFunc, FSig, FFunc> CacheDrawBuilder<'a, VSig, VFunc, FSig, FFunc>
   |      ^^                                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
   |
95 - impl<'a, VSig, VFunc, FSig, FFunc> CacheDrawBuilder<'a, VSig, VFunc, FSig, FFunc>
95 + impl<VSig, VFunc, FSig, FFunc> CacheDrawBuilder<'_, VSig, VFunc, FSig, FFunc>
   |

Check warning on line 38 in src/interface/block.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty line after outer attribute

warning: empty line after outer attribute
  --> src/interface/block.rs:36:5
   |
36 | /     /// TODO: Bool in `Block`. Need to special case vertex attributes.
37 | |     //type Bool: Block<Self> + ToSl<Output = sl::Bool>;
38 | |
   | |_
...
43 |       type Vec2: Block<Self> + ToSl<Output = sl::Vec2> + Default;
   |       ---------------------------------------------------------- the attribute applies to this associated type
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr
   = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default
   = help: if the empty line is unintentional remove it

Check warning on line 164 in src/sl/primitives.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `call_func_def` is never used

warning: function `call_func_def` is never used
   --> src/sl/primitives.rs:164:8
    |
164 | pub fn call_func_def<R: Value>(def: FuncDef, args: Vec<Rc<Expr>>) -> R {
    |        ^^^^^^^^^^^^^

Check warning on line 81 in src/gl/raw/buffer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `is_empty` is never used

warning: method `is_empty` is never used
  --> src/gl/raw/buffer.rs:81:12
   |
40 | impl Buffer {
   | ----------- method in this implementation
...
81 |     pub fn is_empty(&self) -> bool {
   |            ^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default