-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade React Native 0.68.1 to 0.69.0-rc.0 and React 18 w New Arch #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leotm
commented
May 5, 2022
This reverts commit 3706f8b.
Temporarily
This reverts commit 6cb0ffc.
Temporarily
From resolution
Removed by mistake in first commit 3660e51
This reverts commit 76bb940.
This reverts commit 073430f.
- React 17: interface FunctionComponent<P = {}> { (props: PropsWithChildren<P>, ... - React 18: interface FunctionComponent<P = {}> { (props: P, ... - Doc deprecated prop-types error, later remove - Update linter config @typescript-eslint/no-unnecessary-type-arguments doc comment
leotm
added a commit
that referenced
this pull request
May 12, 2022
Upgrade React Native 0.68.1 to 0.69.0-rc.0 and React 18 w New Arch Full details: #585 Including unofficially - React 18.0 -> 18.1+ - TypeScript 4.6 (next) to 4.7 beta - CMake 3.22.1 for NDK 23 on Ubuntu 20.04 And fixing React 18 type errors since - React 17: interface FunctionComponent<P = {}> { (props: PropsWithChildren<P> - React 18: interface FunctionComponent<P = {}> { (props: P
leotm
added a commit
that referenced
this pull request
May 12, 2022
Upgrade React Native 0.68.1 to 0.69.0-rc.0 and React 18 w New Arch Full details: #585 Including unofficially - React 18.0 -> 18.1+ - TypeScript 4.6 (next) to 4.7 beta - CMake 3.22.1 for NDK 23 on Ubuntu 20.04 - Dedupe yarn lockfile deps with overlapping ranges (TODO: CI) And fixing React 18 type errors since - React 17: interface FunctionComponent<P = {}> { (props: PropsWithChildren<P> - React 18: interface FunctionComponent<P = {}> { (props: P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including
children
type errorsIPHONEOS_DEPLOYMENT_TARGET
11.0 to 12.4 bumps forgot earlierReact Native 0.69.0-rc0 Android and iOS Debug builds both generally working well locally on M1 MBP sims/AVDs, w unsupported
cmake 3.22.1
Testing
pod install
ENV['RCT_NEW_ARCH_ENABLED'] = '1'
,:hermes_enabled => true
,:fabric_enabled => true
, flipper 0.138Native Component 'AndroidHorizontalScrollContentView' that calls codegenNativeComponent was not code generated at build time. Please check its definition.
Native Component 'SafeAreaView' that calls codegenNativeComponent ...
nw_socket_handle_socket_event
SO_ERROR
fixed wyarn ios
instead of via Xcode (13.3.1)export default App
only so StorybookUIRoot not parsedNo GitHub Actions
macos-12
iOS CI yet, test mikehardy/buildcache-action@v1Ubuntu 20.04, Gradle 7.4.2 (not yet supported), NDK 23.1.7779620 (not yet supported)
RN
cmake_minimum_required(VERSION 3.13)
Hermes
cmake_minimum_required(VERSION 3.13)
So Ubuntu /sdk/cmake has
cmake_minimum_required(VERSION 3.22.1)
Ensure other ndk's work not in ndk-bundle, then revert forced ndkVersion2124Revert Gradle to 7.3.3Same as below Might rly need to revert[ ]?clean
react
etc18.0.0
[ ]metro-react-native-babel-preset
70.1
70.3 in0.69.0-rc1
[ ] resolutionbabel/core
7.13.10
?0.69.0-rc1
false
fixes gradle node_modules/.../hermes-related missing (sync or multiple cleans, debug)false
fixes gradle node_modules/.../prefab missing (sync or multiple cleans, debug)[ ] flipperfalse
cp index.ts index.js
[ ] Revert AGP 7.3.0-alpha09 to 7.1.1 (7.0.4 pre)Careful RE Google AGP 7.1.1 issue