Parse precursor charge specified in PEPMASS (override CHARGE) #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@levitsky do you think this will be merged soon? |
|
@ypriverol I can merge it any time! Would you like to test it before I do? |
|
@levitsky I have sent you the file examples by slack in EuBIC channel. |
|
Seems to work for me, please feel free to flag any issues. |
|
@levitsky Great! Many Thanks. Could you please release a new version in |
|
@sureshhewabi @ypriverol version 4.7.3 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153.
The
PEPMASSline in MGF can now contain up to 3 numbers, the last one being the precursor charge. If the charge is given on thePEPMASSline, it overridesCHARGEin case the latter is present.