Usability: Improve Code Actions #446
Labels
Comments
scohen
added a commit
that referenced
this issue
Oct 26, 2023
After observing a PR for code actions, it seemed there was much to much busywork in creating them. This PR seeks to remedy that. Now, in order to create a code action, you just need to create a new handler in the `remote_control` app. The server provider now encompasses all code actions, and handles marshalling from and to the protocol. AST transformations now reside in remote_control, which is where they belong. Fixes #446
Merged
scohen
added a commit
that referenced
this issue
Oct 31, 2023
* Code Actions refactor After observing a PR for code actions, it seemed there was much to much busywork in creating them. This PR seeks to remedy that. Now, in order to create a code action, you just need to create a new handler in the `remote_control` app. The server provider now encompasses all code actions, and handles marshalling from and to the protocol. AST transformations now reside in remote_control, which is where they belong. Fixes #446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think code actions' usability can be improved a lot. Right now, there's a router in
serverthat delegates to calls viaRemoteControl.Api. I think we can push the router intoremote_control, pass in the diagnostic information and have the router emit code actions for the diagnostic. This means people would only need to do the work insideremote_control.The text was updated successfully, but these errors were encountered: