Code Actions refactor #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After observing a PR for code actions, it seemed there was much to much busywork in creating them. This PR seeks to remedy that. Now, in order to create a code action, you just need to create a new handler in the `remote_control` app. The server provider now encompasses all code actions, and handles marshalling from and to the protocol. AST transformations now reside in remote_control, which is where they belong. Fixes #446
zachallaun
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Looks like a good direction to me. I think there will be at least one more change to how these work when plugins are able to provide code actions -- it might be that we want all the "built-in" handlers to just use the plugin system to register themselves. Plugin discovery happens in the remote control app though, so it's already better for these to be here.
apps/server/lib/lexical/server/provider/handlers/code_action.ex
Outdated
Show resolved
Hide resolved
apps/remote_control/lib/lexical/remote_control/code_action/handler.ex
Outdated
Show resolved
Hide resolved
100% agree. We need to eat our own dogfood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After observing a PR for code actions, it seemed there was much to much busywork in creating them. This PR seeks to remedy that. Now, in order to create a code action, you just need to create a new handler in the
remote_controlapp.The server provider now encompasses all code actions, and handles marshalling from and to the protocol. AST transformations now reside in remote_control, which is where they belong.
Fixes #446