Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log errors in Server.Transport.StdIO. #684

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Log errors in Server.Transport.StdIO. #684

merged 4 commits into from
Apr 4, 2024

Conversation

Moosieus
Copy link
Collaborator

@Moosieus Moosieus commented Apr 3, 2024

  • Added error log in read loop.
  • Improved error values in header and body parsing.

Moosieus added 2 commits April 3, 2024 11:26
@Moosieus
Log errors in Server.Transport.StdIO.
32f8371 
* Added error log in read loop.
* Improved error values in header and body parsing.
@Moosieus
format files
78de2e4
@Moosieus Moosieus mentioned this pull request Apr 3, 2024
Closed
@Moosieus
Replace String.to_integer/1 with Integer.parse/1 to prevent crash…
79f48ad 
…es in `StdIO`.

* Also fix redundant clause in with expression per credo.
@scohen scohen merged commit 07a132a into lexical-lsp:main Apr 4, 2024
9 checks passed
scohen pushed a commit that referenced this pull request Apr 9, 2024
@Moosieus @scohen
Log errors in Server.Transport.StdIO. (#684)
c095618 
* Log errors in `Server.Transport.StdIO`.
* Added error log in read loop.
* Improved error values in header and body parsing.

* format files

* Stop server when stdio receives `:eof`, and log message.

* Replace `String.to_integer/1` with `Integer.parse/1` to prevent crashes in `StdIO`.
* Also fix redundant clause in with expression per credo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scohen scohen scohen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Moosieus @scohen