Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations on symfony/event-dispatcher:4.3 #637

Closed
wants to merge 2 commits into from

Conversation

chalasr
Copy link
Collaborator

@chalasr chalasr commented Mar 30, 2019

No description provided.

@chalasr chalasr added the Bug label Mar 30, 2019
@chalasr chalasr force-pushed the eventdispatcher-args-order branch from 33b7b53 to ec25ff3 Compare March 30, 2019 00:24
@chalasr chalasr force-pushed the eventdispatcher-args-order branch from ec25ff3 to a6dfbf6 Compare March 31, 2019 10:51
@chalasr chalasr changed the title Fix EventDispatcherInterface::dispatch() deprecation on Symfony 4.3 Fix deprecations on symfony/event-dispatcher:4.3 Mar 31, 2019
@chalasr chalasr marked this pull request as ready for review March 31, 2019 11:16
@chalasr chalasr force-pushed the eventdispatcher-args-order branch from 1074472 to 61e6180 Compare March 31, 2019 11:18
fabpot added a commit to symfony/symfony that referenced this pull request Mar 31, 2019
This PR was merged into the 4.3-dev branch.

Discussion
----------

[EventDispatcher] Fix BC/FC layer

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Fixes
> TypeError: Argument 3 passed to Symfony\Component\EventDispatcher\EventDispatcher::doDispatch() must be an instance of Symfony\Component\EventDispatcher\Event

Spotted in lexik/LexikJWTAuthenticationBundle#637

Commits
-------

caa0ade [EventDispatcher] Fix BC layer
@chalasr chalasr force-pushed the eventdispatcher-args-order branch 4 times, most recently from 46996ba to e40756d Compare March 31, 2019 22:13
@chalasr chalasr force-pushed the eventdispatcher-args-order branch from e40756d to ac0d1fb Compare March 31, 2019 22:17
@chalasr chalasr closed this in 204c2b7 Apr 1, 2019
@chalasr chalasr deleted the eventdispatcher-args-order branch April 17, 2019 12:47
chalasr added a commit that referenced this pull request Apr 17, 2019
This PR was merged into the 2.x-dev branch.

Discussion
----------

Fix FC/BC layer for EventDispatcher

Fix #637

Having Contracts 1.1 doesn't mean EventDispatcher 4.3 is installed ;)

ping @chalasr

Commits
-------

0d564b3 Re-add needed use statements
7d47084 Fix FC/BC layer for EventDispatcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant