Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FC/BC layer for EventDispatcher #644

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Fix FC/BC layer for EventDispatcher #644

merged 2 commits into from
Apr 17, 2019

Conversation

nicolas-grekas
Copy link
Contributor

Fix #637

Having Contracts 1.1 doesn't mean EventDispatcher 4.3 is installed ;)

ping @chalasr

tucksaun
tucksaun approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@tucksaun tucksaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tucksaun
tucksaun reviewed Apr 17, 2019
View reviewed changes
Event/Event.php Outdated Show resolved Hide resolved
@chalasr
Copy link
Collaborator

chalasr commented Apr 17, 2019

Good catch, thanks @nicolas-grekas.

@chalasr chalasr merged commit 0d564b3 into lexik:master Apr 17, 2019
chalasr added a commit that referenced this pull request Apr 17, 2019
@chalasr
bug #644 Fix FC/BC layer for EventDispatcher (nicolas-grekas, chalasr)
be2b78c 
This PR was merged into the 2.x-dev branch.

Discussion
----------

Fix FC/BC layer for EventDispatcher

Fix #637

Having Contracts 1.1 doesn't mean EventDispatcher 4.3 is installed ;)

ping @chalasr

Commits
-------

0d564b3 Re-add needed use statements
7d47084 Fix FC/BC layer for EventDispatcher
@chalasr
Copy link
Collaborator

chalasr commented Apr 17, 2019

Released in v2.6.3

@yceruto yceruto mentioned this pull request Apr 25, 2019
Closed
@chalasr chalasr mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto left review comments

@tucksaun tucksaun tucksaun approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @chalasr @tucksaun @yceruto