Add support for HMAC-SHA256 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the CI check is failing because of this change. |
|
Hi @jrissler, thanks for this PR and being active in the other ones. |
|
Awesome thanks! |
lexmag
requested changes
Aug 26, 2021
lexmag
reviewed
Aug 27, 2021
…upport_for_hmac_sha256
…ther into add_support_for_hmac_sha256
|
@lexmag My bad on delay, should be gtg now :) |
lexmag
approved these changes
Sep 19, 2021
|
@jrissler thank you. 💛 |
This was referenced Sep 19, 2021
|
Awesome thanks @lexmag 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating this library, it's great!
Is this how you envisioned extending it to support other signing methods? If so, I'd love for it to support SHA-256 :)