Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This pull request combines the others #20

Closed
wants to merge 5 commits into from

Conversation

nathany-copia
Copy link

No description provided.

jrissler and others added 5 commits June 9, 2021 16:31
@jrissler
Copy link
Contributor

jrissler commented Jun 9, 2021

I meant to open a PR for this - but latest crypto function changed crypto/3 to crypto/4. It's kind of a minor change and I did in a rush on my fork since I was doing a bunch of upgrades. I will open a PR this week.

Not that it effects any of these changes. Just thought I would mention since there is very low activity on this library :)

@nathany-copia
Copy link
Author

Thanks @jrissler

@jrissler
Copy link
Contributor

jrissler commented Aug 25, 2021

@lexmag you around - couple PR's that would be good to get merged in.

@lexmag
Copy link
Owner

lexmag commented Aug 26, 2021

@lexmag you around - couple PR's that would be good to get merged in.

Just replied in #15 (comment).

It would actually be easier to review a merge smaller and more targeted PRs.
From what I see it should be:

@lexmag
Copy link
Owner

lexmag commented Sep 19, 2021

I'm closing this PR since it is practically only #17 left.

@lexmag lexmag closed this Sep 19, 2021
@nathany-copia nathany-copia deleted the main branch January 5, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants