Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check rule exists before create #2741

Merged
merged 4 commits into from
Mar 27, 2024

fix

dd295d2
Select commit
Loading
Failed to load commit list.
Merged

fix: check rule exists before create #2741

fix
dd295d2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 27, 2024 in 0s

63.55% (+0.04%) compared to 520570e

View this Pull Request on Codecov

63.55% (+0.04%) compared to 520570e

Details

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.55%. Comparing base (520570e) to head (dd295d2).
Report is 1 commits behind head on master.

Files Patch % Lines
internal/server/rule_manager.go 55.56% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2741      +/-   ##
==========================================
+ Coverage   63.51%   63.55%   +0.04%     
==========================================
  Files         340      340              
  Lines       39016    39024       +8     
==========================================
+ Hits        24780    24799      +19     
+ Misses      12067    12056      -11     
  Partials     2169     2169

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov