Unknown port types handled with unknown instead of Present
#1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
axmmisaka
force-pushed
the
present-unknown
branch
from
e6bffa1
to
cb53d79
Compare
lhstrh
commented
Jul 1, 2023
There was a problem hiding this comment.
Looks good, modulo suggested changes (to be applied after merging lf-lang/reactor-ts#168)
axmmisaka
added a commit
to lf-lang/reactor-ts
that referenced
this pull request
Jul 1, 2023
…and use TS Tuple (#168) This is a squashed commit. This commit: 1. Removed `Present` and replaced with `unknown`. 2. Removed `Args` and `Trigger` in reaction and replaced them with TypeScript Tuples. Also see lf-lang/lingua-franca#1857 --------- Co-authored-by: Marten Lohstroh <marten@berkeley.edu>
lhstrh
changed the title
unknown instead of Present
axmmisaka
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type constraint
extends Present(withPresentbeing the type that included all types butundefined) was inconvenient and non-standard from the perspective of TypeScript. Removing this awkwardness will probably also make it more straightforward to offer support for generic reactors in LF. See lf-lang/reactor-ts#168 for related changes made in the runtime.