-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Patmos platform on static-schedule-single-thread branch by direct Makefile #2315
Conversation
In general, as it is mostly Patmos-specific changes, it looks fine. However, 2 points: (1) should a change in core/threaded/scheduler_static.c really be part of this commit? @lsk567 needs to approve those changes. (2) is test/C the best place for Patmos-specific README and Makefile? |
About core/threaded/scheduler_static.c, we only needed to comment out #include "semaphore.h" in line 55 to get rid of a compile error; other changes are made by the formatter. |
@EhsanKhodadad Thanks for working on the Patmos support and get them to work with the static scheduler. However, I don't think these files belong in this lingua-franca repository. They seem to belong to the reactor-c repository. Suggestions for a proper integration:
But given that this branch for single-threaded execution is not a stable solution (code from the Then, we can work on the proper Patmos integration when we can print static schedules into a |
dba3117
to
27ef659
Compare
Is PR still relevant considering there is #2383? Can it be closed? |
No description provided.