Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Patmos platform #2383

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

EhsanKhodadad
Copy link
Collaborator

No description provided.

@lhstrh
Copy link
Member

lhstrh commented Aug 2, 2024

@EhsanKhodadad, I enabled CI for you, but it looks like there are still some test failures. Please address those first.

@EhsanKhodadad
Copy link
Collaborator Author

@EhsanKhodadad, I enabled CI for you, but it looks like there are still some test failures. Please address those first.

Thank you for enabling CI. The tester has not found a header file in the t-crest repository, because t-crest hasn't cloned on the tester's machine.

@lhstrh
Copy link
Member

lhstrh commented Aug 3, 2024

Got it. Can you fix it in the workflow?

@EhsanKhodadad
Copy link
Collaborator Author

Got it. Can you fix it in the workflow?

Sure

@lhstrh
Copy link
Member

lhstrh commented Aug 22, 2024

Btw, I noticed tests in your fork were failing. Here's a fix for that: #2402

path: core/src/main/resources/lib/c/reactor-c
ref: ${{ inputs.runtime-ref }}
if: ${{ inputs.runtime-ref }}
- name: Run Patmos smoke tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step isn't actually running any tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants