Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ReazonSpeech recipe #1330

Merged
merged 12 commits into from
May 29, 2024
Merged

Conversation

Triplecq
Copy link
Contributor

@Triplecq Triplecq commented May 2, 2024

ReazonSpeech is an open-source dataset that contains a diverse set of natural Japanese speech, collected from terrestrial television streams. It contains more than 35,000 hours of audio.

The dataset is available on Hugging Face. For more details, please visit:

fujimotos and others added 4 commits December 18, 2023 15:47
I created this recipe by copying "aishell4" recipe, and stripping
the most of the contents.

Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
…/lhotse

Experiemntal version for ReazonSpeech
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a download method if it’s publicly available?

duration=item["duration"],
channel=0,
language="Japanese",
speaker=str(idx),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If speaker information is not available, just omit this field.

from lhotse.utils import Pathlike


def prepare_reazonspeech(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since reazonspeech is a large dataset this method may require a lot of cpu memory before it writes anything. Would you consider modifying the recipe to resemble gigaspeech more closely? It writes examples as it processes them for reduced memory usage https://github.com/lhotse-speech/lhotse/blob/master/lhotse/recipes/gigaspeech.py

@pzelasko
Copy link
Collaborator

pzelasko commented May 2, 2024

Also, could you add an entry in the dataset table in docs/corpus.rst?

@Triplecq
Copy link
Contributor Author

Triplecq commented May 2, 2024

Thanks for your quick feedback and suggestions! I will get back to your comments soon. :)

pzelasko
pzelasko previously approved these changes May 20, 2024
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, LGTM once tests pass

@Triplecq
Copy link
Contributor Author

Thanks for your quick feedback! I'll fix those checks very soon. :)

pzelasko
pzelasko previously approved these changes May 21, 2024
@pzelasko pzelasko enabled auto-merge (squash) May 21, 2024 00:20
@pzelasko
Copy link
Collaborator

It seems the tests are failing on importing num2words, can you make it into a local import guarded by is_module_available (pls search lhotse sources for is_module_available to see an example of import guard for optional dependencies).

auto-merge was automatically disabled May 29, 2024 18:04

Head branch was pushed to by a user without write access

@Triplecq
Copy link
Contributor Author

@pzelasko Thanks for the note! I've already changed it to local import. Please feel free to let me know if there's anything else I need to improve. :)

pzelasko
pzelasko previously approved these changes May 29, 2024
@pzelasko pzelasko added this to the v1.24.0 milestone May 29, 2024
@pzelasko pzelasko enabled auto-merge (squash) May 29, 2024 20:33
@pzelasko pzelasko merged commit c778520 into lhotse-speech:master May 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants