Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated hasBounds default value. Fixes #223 #224

Merged
merged 1 commit into from
Apr 5, 2016
Merged

Updated hasBounds default value. Fixes #223 #224

merged 1 commit into from
Apr 5, 2016

Conversation

brollb
Copy link
Contributor

@brollb brollb commented Mar 14, 2016

No description provided.

@liabru
Copy link
Owner

liabru commented Apr 5, 2016

Shouldn't it be !!options.bounds since render wouldn't be defined at that point?

@brollb
Updated hasBounds default value. Fixes liabru#223
053ea76 
WIP liabru#223 changed 'render' to 'options'
@brollb brollb force-pushed the 223-bounds-ignored-in-renderer branch from d254f85 to 053ea76 Compare April 5, 2016 19:54
@brollb
Copy link
Contributor Author

brollb commented Apr 5, 2016

good catch - my bad

@liabru liabru merged commit 1944f6a into liabru:master Apr 5, 2016
@liabru
Copy link
Owner

liabru commented Apr 5, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brollb @liabru