Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiler warnings for GNU and Clang (DO NOT MERGE) #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikkoi
Copy link
Contributor

@mikkoi mikkoi commented Oct 20, 2019

When building CMake Debug.

@mikkoi mikkoi force-pushed the add-compiler-warnings-to-cmake branch 2 times, most recently from 20d5cb7 to 3fc9e9d Compare October 22, 2019 06:52
@brarcher
Copy link
Contributor

Does you know if the Travis-CI or AppVeyor builds are Release or Debug? That is, will these flags be used in the default build for Check, and is there any test coverage on Travis-CI or AppVeyor for using the flags if it is not the default?

@mikkoi
Copy link
Contributor Author

mikkoi commented Oct 28, 2019

Travis-CI builds are all 'Debug' unless specifically defined as 'Release' (currently not). The warnings are visible in Travis logs. They are only warnings, so the builds will not fail.

The purpose is the same as with running Cppcheck during build: emit all the warnings we can to inform the developer.

@mikkoi mikkoi changed the title Add compiler warnings for GNU and Clang Add compiler warnings for GNU and Clang (DO NOT MERGE) Oct 28, 2019
When building CMake Debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants