Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compiler warnings for GNU and Clang (DO NOT MERGE) #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add compiler warnings for GNU and Clang (DO NOT MERGE) #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,55 @@ set(CMAKE_C_STANDARD 99)
set(CMAKE_C_STANDARD_REQUIRED ON)
set(CMAKE_C_EXTENSIONS ON) # Use GNU extensions and POSIX standard

# #############################################################################
# Static analysis and code quality

# Run analysis only when the build type is Debug,
# not any of the Release variants.
# Different tests are only executed when the corresponding
# tools are available. Presence in the system is checked individually.

if(CMAKE_BUILD_TYPE STREQUAL "Debug")

# Compiler based code analysis
# Add other compilers if they are compatible
# or create another if().
if(
CMAKE_C_COMPILER_ID STREQUAL "GNU"
OR CMAKE_C_COMPILER_ID STREQUAL "Clang"
OR CMAKE_C_COMPILER_ID STREQUAL "AppleClang")

string(APPEND WARNING_COMPILER_FLAGS
" -Wall"
" -Wextra"
" -pedantic"
" -Wconversion"
" -Wsign-conversion"
" -Wpedantic"
" -fno-omit-frame-pointer"
" -Wpointer-arith -Wstrict-prototypes"

# " -Wlogical-op"
#" -fsanitize=address" # Disable sanitizers to activate libasan for valgrind.
# " -static-libasan"

# https://dwheeler.com/secure-programs/Secure-Programs-HOWTO.html#C-CPP
" -Wmissing-prototypes -Wmissing-declarations"
" -Wstrict-prototypes -Wpointer-arith"
" -Wwrite-strings -Wcast-qual -Wcast-align"
" -Wbad-function-cast"
" -Wformat-security -Wformat-nonliteral"
" -Wmissing-format-attribute"
" -Winline"

" -funsigned-char"
)
string(APPEND CMAKE_C_FLAGS ${WARNING_COMPILER_FLAGS})
string(APPEND CMAKE_CXX_FLAGS ${WARNING_COMPILER_FLAGS})

endif()
endif()

###############################################################################
# Option
option(CHECK_ENABLE_TESTS
Expand Down