Improve handling of complex plurals

[Changaco]

See liberapay/salon#125 (comment).

[Changaco]

I've opened an issue upstream: python-babel/babel#530.

[Changaco]

Sneaked in a commit to take care of #696.

[trebmuh]

👍

[Changaco]

@pskosinski finds this confusing.

[AllDragonsAreDead]

Now, after reading discussion starting here liberapay/salon#125 (comment) I do understand what's going on. Although, when I visited Weblate to check if anything needs translating, noticed all the failed tests and <unused singular (hash=… as source strings I thought something in the Liberapay's or Weblate's source code got broken. It was not intuitive to me. Now it seems like a good solution though, I guess.

[AllDragonsAreDead]

Seems like the strings whose msgid's got converted, e.g.:

-msgid "Your donations will be funded for {n} weeks ({0})"
+msgid "<unused singular (hash=578803aaecf90d69fa606ab0f5a693e9)>"

stay untranslated on the website, even that they are translated on the Weblate. It's easiest to notice if you switch language to a fully translated language (e.g. French, German) and scroll down to "Recent activity" section. All the strings there are in English, even that they were getting replaced with their translations some time ago.

[Changaco]

/o\

Working on a fix…

[Skybladev2]

@Changaco Can you please clarify when this fix will be reflected to Weblate?
I see this at the moment:

[Changaco]

@Skybladev2 I'm not sure what you were asking, but your comment made me realize that the source string in your screenshot was wrong because we do use the singular. I've fixed it in b29b73b.

[Skybladev2]

@Changaco I see several errors in source strings, you can see it by following this link: https://hosted.weblate.org/translate/liberapay/core/ru/?type=check%3Apython_brace_format&offset=0

Is it Weblate issue or Liberapay issue?

[Changaco]

The source strings are exactly what they're supposed to be. Weblate's warnings and errors are about the differences between the singular source string and its translation, they can be dismissed.