jnigen: Update mmacosx-version-min to 10.9 #5740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intrigus
reviewed
Aug 19, 2019
| "-c -Wall -O2 -arch i386 -DFIXED_POINT -fmessage-length=0 -fPIC -mmacosx-version-min=10.5", | ||
| "-shared -arch i386 -mmacosx-version-min=10.5"); | ||
| return mac; | ||
| throw new RuntimeException("MacOsX i386 has is deprecated."); |
There was a problem hiding this comment.
"MacOsX i386 has is deprecated." -> "MacOsX i386 is deprecated."
|
Closed in favor of #5701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5608
Passing
-mmacosx-version-min=10.9will make the compiler uselibc++instead oflibstdc++6Also included is an exception when trying to use MacOsx and 32bit. Newer xcode releases do not support it at all.
See also nodejs/node-gyp#469 and Homebrew/homebrew-core#14271