Fix build & install on osx #31
Conversation
Makefile
Outdated
| # Lua-related configuration | ||
| MPACK_LUA_VERSION ?= 5.1.5 | ||
| MPACK_LUA_VERSION_NOPATCH = $(basename $(MPACK_LUA_VERSION)) | ||
| LUA_URL ?= https://lua.org/ftp/lua-$(MPACK_LUA_VERSION).tar.gz | ||
| LUAROCKS_URL ?= https://github.com/keplerproject/luarocks/archive/v2.2.0.tar.gz | ||
| ifeq ($(PLATFORM), Darwin) | ||
| LUA_TARGET ?= macosx | ||
| else | ||
| LUA_TARGET ?= linux |
There was a problem hiding this comment.
looking again, it seems like LUA_TARGET was intended to be set by the caller or else default to "linux".
So adding the uname call seems questionable, because it would presumably fail on Windows. Why not pass LUA_TARGET from the caller (lua-client in your case specifically)?
There was a problem hiding this comment.
@justinmk good point about windows, I should drop the use of uname.
I'm not following your point about the caller being lua-client -- LUA_TARGET here as I understand it is just about building the local lua in .deps for a local build. I'm not seeing how it affects downstream libraries.
An alternative to trying to have make work out of the box on osx is to update README with build instructions for osx users that amount to LUA_TARGET=macosx make. WDYT?
There was a problem hiding this comment.
An alternative to trying to have
makework out of the box on osx is to updateREADMEwith build instructions for osx users that amount toLUA_TARGET=macosx make. WDYT?
Yes. And if there's a LUA_TARGET for Windows that also helps :)
not following your point about the caller being
lua-client--LUA_TARGEThere as I understand it is just about building the local lua in.depsfor a local build.
oops, right. I didn't inspect where it was used.
There was a problem hiding this comment.
@justinmk I've updated the PR so that it fixes the build error and only provides instructions on building lua for non-linux platforms, including windows.
LMK if you'd like to see any other tweaks before merging.
There was a problem hiding this comment.
@justinmk I've similarly updated neovim/lua-client#55
hjdivad
force-pushed
the
hjdivad/osx
branch
2 times, most recently
from
b5cd85b to
5789ac7
Compare
Fix building on osx and add install instructions for non-linux platforms. Trying to build & install on linux leads to three errors: 1. Lua doesn't build 2. libmpack doesn't build 3. neovim/lua-client doesn't build With this PR and libmpack/libmpack-lua#31 I'm able to build the lua client on osx. ```bash uname -a # Darwin hostname 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2 022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64 ``` On `master` ```bash make # ... # gcc -o lua lua.o liblua.a -lm -Wl,-E -ldl -lreadline -lhistory -lncurses # ld: unknown option: -E # clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` This error installing lua is fixed by specifying a `LUA_TARGET` of `macosx` instead of `linux`. In general, several `LUA_TARGET`s can be specified. I've added them to `README.md`. The source of truth is `make` from lua itself, e.g. ```bash cd .deps/5.1.5/src/lua && make # Please do # make PLATFORM # where PLATFORM is one of these: # aix ansi bsd freebsd generic linux macosx mingw posix solaris # See INSTALL for complete instructions. ``` The next issue is that `libmpack` doesn't build. See [libpack-lua#131](libmpack/libmpack-lua#31). Apply the fix locally and install via: ```bash cd ~/src/libmpack/libmpack-lua/ ~/src/neovim/lua-client/.deps/usr/bin/luarocks make ``` With `libmpack` and lua installed `make` now errors with: ``` cc -g -fPIC -Wall -Wextra -Werror -Wconversion -Wextra -Wstrict-prototypes -ped antic -o nvim/native.o -c nvim/native.c -I/Users/hjdivad/src/neovim/lua-client/ .deps/usr/include cc -shared -fPIC nvim/native.o -o nvim/native.so Undefined symbols for architecture x86_64: "_luaL_checkinteger", referenced from: _pid_wait in native.o "_luaL_register", referenced from: _luaopen_nvim_native in native.o "_lua_createtable", referenced from: _luaopen_nvim_native in native.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` This is fixed by adding `-undefined dynamic_lookup` to `LDFLAGS` and not relying on it being the default behaviour.
Specify build instructions for non-linux platforms.
Seems the OS X requires _C99_SOURCE or similar to define snprintf. Add that define.
This fixes some build issues on osx of the form: ``` ./mpack-src/src/conv.h:7:9: error: 'long long' is an extension when C99 mode is not enabled [-Werror,-Wlong-long] typedef long long mpack_sintmax_t; ```
Fix building on osx and add install instructions for non-linux platforms.
uname -a # Darwin hostname 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2 022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64On
masterThis error installing lua is fixed by specifying a
LUA_TARGETofmacosxinstead oflinux. In general, severalLUA_TARGETs can be specified. I've added them toREADME.md. The source of truth ismakefrom lua itself, e.g.After building lua successfully there are still two build errors for libmpack:
and a few occurrences of:
The first is fixed by #30 (this PR includes @nashidau's commit) and the second is fixed by adding
-std=c99toCFLAGS.With these changes I'm able to build and install, which satisfies the dep for neovim/lua-client.