This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix building on osx and add install instructions for non-linux platforms.
Trying to build & install on linux leads to three errors:
With this PR and libmpack/libmpack-lua#31 I'm able to build the lua client on osx.
uname -a # Darwin hostname 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2 022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64
On
master
This error installing lua is fixed by specifying a
LUA_TARGET
ofmacosx
instead oflinux
. In general, severalLUA_TARGET
s can be specified. I've added them toREADME.md
. The source of truth ismake
from lua itself, e.g.The next issue is that
libmpack
doesn't build. See libpack-lua#131. Apply the fix locally and install via:With
libmpack
and lua installedmake
now errors with:This is fixed by adding
-undefined dynamic_lookup
toLDFLAGS
and not relying on it being the default behaviour.