This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
hide watchdog behind cgo flag #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Jan 15, 2022
|
I think it will, but I wouldn't merge this before our go-ipfs PR is green: libp2p/go-libp2p#1267. Working on it... |
|
I took a rabbit hole and ended up here. The testing did not catch that go-libp2p v0.17.0 is broken on darwin, openbsd etc. or is there a special trigger? I don't think CGO is an option on all those platforms. But how did tests succeed? |
hsanjuan
added a commit
to ipfs-cluster/ipfs-cluster
that referenced
this pull request
Mar 25, 2022
go-libp2p-connmgr does not build on some architectures due to some dependencies (libp2p/go-libp2p-connmgr#103). By extension, go-libp2p does not build when using the connmgr. The fix is in master.
hsanjuan
added a commit
to ipfs-cluster/ipfs-cluster
that referenced
this pull request
Mar 25, 2022
go-libp2p-connmgr does not build on some architectures due to some dependencies (libp2p/go-libp2p-connmgr#103). By extension, go-libp2p does not build when using the connmgr. The fix is in master.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.