move the go-libp2p-connmgr here #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Don't ask the system for the time when checking if we should close each connection (potentially thousands of systemcalls!). 2. Log from outside the lock. 3. Log the event around the entire connection closing operation. 4. Preallocate the slice holding the connections to be closed.
It's unused.
faster, cleaner connection closing
Add docs to BasicConnMgr
Improve Test Coverage
Fix concurrency and silence period not being honoured
Users can call Protect() to save a peer from pruning, and Unprotect() to remove the protection. Protected peers don't count towards the target quantity to prune during a connection manager cycle.
Also slightly reworked the loop that selects candidates to prune to make it better behaved. Before, if we needed to prune N connections, we preselected N and ended up doing nothing if they happened to be in the grace period. Now we skip over them and prune ungraced connections until we meet our target.
Add peer protection capability (implementation)
Implement UpsertTag
- fix potential concurrent modification of connection map from concurrent connects/disconnects by locking the segment - don't spawn goroutines on every connect during trims
update go-log to v2
unexport the config
fix race condition in getConnsToClose
add an error return value to the constructor
As trims are triggered by a time.Ticker, this would lead to roughly every second trim being skipped. It also makes calling TrimOpenConns pointless.
remove check for the last trim time when trimming
introduce WithGracePeriod and WithSilencePeriod configuration options
fix flaky tests caused by super short silence periods
aggressively trim connections when we're running out of memory
make emergency trimming optional, disabled by default
vyzo
approved these changes
Jan 17, 2022
| @@ -46,6 +47,7 @@ require ( | |||
| github.com/multiformats/go-varint v0.0.6 | |||
| github.com/prometheus/common v0.30.0 // indirect | |||
| github.com/prometheus/procfs v0.7.3 // indirect | |||
| github.com/raulk/go-watchdog v1.2.0 | |||
There was a problem hiding this comment.
It's hidden behind the cgo flag (libp2p/go-libp2p-connmgr#103).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is easy, as go-libp2p doesn't yet depend on this package yet.
We will initialize a default connection manager in an upcoming PR very soon though.