This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
pass the peer ID to SecureInbound in the SecureTransport and SecureMuxer #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The peer ID may be empty. This will be the common case. In that case, connections from any peer are accepted.
marten-seemann
force-pushed
the
secure-inbound-peer-id
branch
from
9f55be3
to
b0e6ce9
Compare
|
Note: I intend to cut a new go-libp2p-core release (v0.10.0) right after this PR is merged. This will allow us to make the necessary changes to -tls, -noise, -upgrader etc. |
This was referenced Sep 5, 2021
Stebalien
approved these changes
Sep 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peer ID may be empty. This will be the common case. In that case, connections from any peer are accepted.
See libp2p/go-libp2p-transport-upgrader#82 (comment).