This repository has been archived by the owner on May 26, 2022. It is now read-only.
add the peer ID to SecureInbound #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Sep 8, 2021
| @@ -243,7 +243,7 @@ func (s *secureSession) handleRemoteHandshakePayload(payload []byte, remoteStati | |||
| } | |||
|
|
|||
| // if we know who we're trying to reach, make sure we have the right peer | |||
| if s.initiator && s.remoteID != id { | |||
There was a problem hiding this comment.
Don't we want to assert that we know the remote peer ID if we're the initiator?
There was a problem hiding this comment.
I want to get to the point where we can dial a multiaddr and learn the remote peer ID from the handshake, but this PR is probably not the place to work towards that. Will adjust the logic.
There was a problem hiding this comment.
Yeah, I agree. We just need to be careful about that to make sure we can't get tricked into dialing the wrong peer.
Although I guess we enforce this in the swarm so it's probably not an issue.
marten-seemann
force-pushed
the
check-peer-id-on-inbound
branch
from
df52653
to
52c3bda
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on libp2p/go-libp2p-core#211.