This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
trace the scope name as a JSON object #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for easy filtering using standard JSON tooling (e.g. jq) to filter for a specific scope.
marten-seemann
commented
Jun 7, 2022
| if s.SpanID > 0 { | ||
| class = addToClass(class, "span") | ||
| } | ||
| return json.Marshal(struct { |
There was a problem hiding this comment.
It's super annoying that standard library encoding/json still doesn't allow allocation-free marshaling of arbitrary structs. At leasts it's a stack allocation though.
vyzo
reviewed
Jun 7, 2022
| ps = newResourceScope(l, nil, fmt.Sprintf("%s.peer:%s", s.name, p), s.rcmgr.trace, s.rcmgr.metrics) | ||
| sn := s.name | ||
| sn.Peer = p | ||
| ps = newResourceScope(l, nil, sn, s.rcmgr.trace, s.rcmgr.metrics) |
| ps = newResourceScope(l, nil, fmt.Sprintf("%s.peer:%s", s.name, p), s.rcmgr.trace, s.rcmgr.metrics) | ||
| sn := s.name | ||
| sn.Peer = p | ||
| ps = newResourceScope(l, nil, sn, s.rcmgr.trace, s.rcmgr.metrics) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for easy filtering using standard JSON tooling (e.g. jq) to filter for a specific scope.
The idea behind this is that we get rid of the conversion step to get an event log (#43).
Builds on top of #44.