Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

trace the scope as a JSON object #52

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

marten-seemann
Copy link
Contributor

This is a different implementation of #45, that leaves the name of a scope a string. Instead, when tracing, we parse the name and determine the scope.

Closes #45.

@marten-seemann marten-seemann requested a review from vyzo June 19, 2022 17:23
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is better in that it leaves the ontological name unmollested.

We might want to cache the parsed scope class in the scope itself, not sure if it has any perf implications.

@marten-seemann
Copy link
Contributor Author

We might want to cache the parsed scope class in the scope itself, not sure if it has any perf implications.

That would almost be #45 then...

@marten-seemann marten-seemann merged commit a18fe79 into master Jun 20, 2022
@marten-seemann marten-seemann deleted the trace-scope-class branch June 20, 2022 08:00
@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
41 tasks
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants