This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Upgrade to use latest libp2p modules #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct libp2p modules calls, accordingly to the current APIs.
daviddias
suggested changes
Nov 28, 2016
| @@ -23,10 +23,11 @@ function Bootstrap (peerList, options, swarm) { | |||
| var mh = multiaddr(peerCandidate.split('/').splice(0, 5).join('/')) | |||
| var peerId = Id.createFromB58String(peerCandidate.split('/').splice(6)[0]) | |||
|
|
|||
| var p = new Peer(peerId, [mh]) | |||
| var p = new Peer(peerId) | |||
There was a problem hiding this comment.
This should be async with the new peer-info
| var Peer = require('peer-info') | ||
| var Swarm = require('libp2p-swarm') | ||
| var tcp = require('libp2p-tcp') | ||
| var Tcp = require('libp2p-tcp') |
|
@nunofmn could you also update the travis and circle configs to the latest ones in conformance with js-ipfs? also, |
|
Changes Unknown when pulling 6cd880e on nunofmn:16-upgrade-libp2p-modules into ** on libp2p:master**. |
daviddias
approved these changes
Nov 30, 2016
| "pre-commit": "^1.1.2" | ||
| }, | ||
| "dependencies": { | ||
| "ipfs-logger": "^0.1.0", | ||
| "ipfs-logger": "^0.1.1", |
There was a problem hiding this comment.
This is no longer used, could you switch it to use debug instead?
|
Changes Unknown when pulling 9187cfa on nunofmn:16-upgrade-libp2p-modules into ** on libp2p:master**. |
1 similar comment
|
Changes Unknown when pulling 9187cfa on nunofmn:16-upgrade-libp2p-modules into ** on libp2p:master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #16