This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: stream close #116
Merged
fix: stream close #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
achingbrain
suggested changes
Oct 21, 2020
test: verify abort/reset errors are correct
|
Added the assertions and removed the unused error param from the abort call, should be good now. |
achingbrain
approved these changes
Oct 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more aggressive closures to streams on abort and reset. It was previously possible for unwritten streams to not properly end when aborted/reset, which would result in them not properly notifying libp2p/application code of the termination. This could also result in streams lingering.
I'd like to do some more clean up here but am reserving that for #115, which will create some breaking behavior.
This should also resolve part of #113.