fix: ensure streams are closed on connection close #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
force-pushed
the
fix/stream-close
branch
from
1953175 to
e6ca831
Compare
|
CI failures are currently due to the latest release of node 15 on current. We'll resolve those separately. |
achingbrain
requested changes
Oct 21, 2020
| connection.stat.status = 'closed' | ||
| this.onConnectionEnd(connection) | ||
| // Wait for close to finish before notifying of the closure | ||
| (async () => { |
There was a problem hiding this comment.
Can this anonymous function throw? The error needs to be handled if so.
There was a problem hiding this comment.
Yes, in theory the connection.close could throw although that should be rare. Good catch, a handler for this to log the error
|
npm 7 broke how we're doing some dev testing, #790, so I've locked ci on Node 14 for now to avoid the CI failures. |
achingbrain
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that whenever a connection is closed, any remaining streams on the connection are aborted.